Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: goreleaser compatibility issue #3347

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: goreleaser compatibility issue #3347

merged 2 commits into from
Jun 10, 2024

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Jun 10, 2024 •
edited
Loading

goreleaser 2.0 has been released and brought some nice but incompatible changes: https://github.com/grafana/pyroscope/actions/runs/9441815396/job/26003085405

The change is already in weekly/f70: https://github.com/grafana/pyroscope/actions/runs/9443073885

@kolesnikovae kolesnikovae marked this pull request as ready for review June 10, 2024 06:14
@kolesnikovae kolesnikovae requested a review from a team as a code owner June 10, 2024 06:14
@simonswine
Copy link
Contributor

Thanks for fixing this ❤️

@simonswine simonswine merged commit cb303c1 into main Jun 10, 2024
16 checks passed
@simonswine simonswine deleted the fix/goreleaser-2 branch June 10, 2024 14:21
simonswine pushed a commit that referenced this pull request Jun 21, 2024
@kolesnikovae @simonswine
fix: goreleaser compatibility issue (#3347)
04fd419 
* fix: goreleaser compatibility issue

* fix: bump goreleaser dependency
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jun 21, 2024
@simonswine
Update release workflow to be v2 compatible
157a7e9 
This was missed as part of grafana#3347
@simonswine simonswine mentioned this pull request Jun 21, 2024
Merged
simonswine added a commit that referenced this pull request Jun 21, 2024
@simonswine
Update release workflow to be v2 compatible (#3375)
a7a0a82 
This was missed as part of #3347
github-actions bot pushed a commit that referenced this pull request Jun 21, 2024
@simonswine @grafana-delivery-bot
Update release workflow to be v2 compatible (#3375)
6aba8a1 
This was missed as part of #3347

(cherry picked from commit a7a0a82)
@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Merged
simonswine added a commit that referenced this pull request Jun 21, 2024
@github-actions @simonswine
Update release workflow to be v2 compatible (#3375) (#3376)
3d664fc 
This was missed as part of #3347

(cherry picked from commit a7a0a82)

Co-authored-by: Christian Simon <simon@swine.de>
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jun 21, 2024
@simonswine
Ensure we use a fixed goreleaser version in github actions
55055e7 
Avoids problems like encountered in grafana#3347
@simonswine simonswine mentioned this pull request Jun 21, 2024
Merged
simonswine added a commit that referenced this pull request Jun 21, 2024
@simonswine
Ensure we use a fixed goreleaser version in github actions (#3377)
1f7d0f1 
Avoids problems like encountered in #3347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolesnikovae @simonswine @korniltsev